Alexander Larsson [Wed, 5 Dec 2012 13:51:23 +0000 (14:51 +0100)]
GtkLabel: Rely on the new pango support for context change tracking
Now that Pango tracks changes to the context automatically there is
no need to do it manually in e.g. style-updated or direction-changed,
in fact the only case we have to care about is when we re-create
the PangoContext due to a screen change, so we only have to clear
the layouts in GtkLabel in screen-changed.
This means we're not clearing all the layouts whenever the state changes,
which happens to every widget when the window is unfocused, which helps
performance a lot.
https://bugzilla.gnome.org/show_bug.cgi?id=340066
Alexander Larsson [Thu, 6 Dec 2012 18:50:47 +0000 (19:50 +0100)]
Require new pango with automatic tracking of PangoContext changes
Pango 1.32.4 has a feature where any PangoLayout automatically handles
the case where a PangoContext is changed. We want to rely on this to
avoid having to clear layouts too often, so we make this a hard dep.
Benjamin Otte [Thu, 6 Dec 2012 01:55:22 +0000 (02:55 +0100)]
stylecontext: Deprecate gtk_style_context_get_font()
This is for a very simple reason: The getter is returning a const value
and the font isn't const anymore. So we need to store the font
description somewhere but we can't reuse it as it's changing all the
time (yay animations, yay inherited values). Sucks.
So keep the hack in here but deprecate the function.
Benjamin Otte [Thu, 6 Dec 2012 01:54:18 +0000 (02:54 +0100)]
switch: Remove hack to change text size
The same effect can now be achieved via
.switch { font-size: smaller; }
so there is no need to hardcode things.
Benjamin Otte [Thu, 6 Dec 2012 01:53:43 +0000 (02:53 +0100)]
gtk: Query font size directly
... instead of calling gtk_style_context_get_font() and then
pango_font_description_get_size().
Benjamin Otte [Thu, 6 Dec 2012 01:51:04 +0000 (02:51 +0100)]
gtk: Use gtk_style_context_get()
... instead of soon-to-be-deprecated gtk_style_context_get_font().
Benjamin Otte [Thu, 6 Dec 2012 01:47:24 +0000 (02:47 +0100)]
gtk: Use context's font
Instead of using gtk_style_context_get_font() in
pango_context_get_metrics(), use pango_context_get_font_description().
The context contains the font description we are about to use after all.
Benjamin Otte [Thu, 6 Dec 2012 01:30:57 +0000 (02:30 +0100)]
tests: Don't call to-be-deprecated function
Benjamin Otte [Thu, 6 Dec 2012 01:18:58 +0000 (02:18 +0100)]
aboutdialog: Add text tag to get small text
This is to get rid of gtk_widget_override_font() and
gtk_style_context_get_font().
FIXME: This should probably be done by the theme somehow?
Benjamin Otte [Wed, 5 Dec 2012 17:41:40 +0000 (18:41 +0100)]
stylecontext: Always recompute font
This is necessary because values in a GtkCssComputedValues can change
now. So if the font-size is inherited or animated, the cached value will
be outdated.
Fixes the fontchooser preview not updating.
Daniel Mustieles [Wed, 5 Dec 2012 19:10:39 +0000 (20:10 +0100)]
Updated Spanish translation
Daniel Mustieles [Wed, 5 Dec 2012 19:10:27 +0000 (20:10 +0100)]
Updated Spanish translation
Jasper St. Pierre [Mon, 16 Jul 2012 01:14:33 +0000 (21:14 -0400)]
treemodelfilter: Make the constructor binding friendly
This means reffing the root in the set property implementation,
rather than in the constructor. We don't need to unref the root
on set, as it's a CONSTRUCT_ONLY property.
https://bugzilla.gnome.org/show_bug.cgi?id=680065
Aleksander Morgado [Wed, 5 Dec 2012 10:15:42 +0000 (11:15 +0100)]
GdkBroadwayDisplay: include proper port number in error trace
Aleksander Morgado [Wed, 5 Dec 2012 10:15:11 +0000 (11:15 +0100)]
GdkBroadwayDisplay: initialize GError before using it
Alexander Larsson [Tue, 4 Dec 2012 20:26:37 +0000 (21:26 +0100)]
Revert "Don't queue resize for hidden widgets without a size group"
This seems to break redraw of the middle pane in glade.
This reverts commit
faaae520c98af1c27ca1e97ca8f33655ec6b575e.
Alexander Larsson [Tue, 4 Dec 2012 15:38:23 +0000 (16:38 +0100)]
Don't unnecessarily queue resize in GtkWindow.style_updated
GtkWindow always queues a resize on style updates if there is
a grip, because it may have been the grip size style properties
that changed. However, even if it *were*, and it likely wasn't
that would not affect the windows size request, so no need
to queue a resize.
Alexander Larsson [Tue, 4 Dec 2012 15:53:06 +0000 (16:53 +0100)]
Don't queue resize for hidden widgets without a size group
queue_resize basically tells the parent widget that it may need
to pick a different size/layout. However, for a hidden child widget
that should never be needed. It may be that the widget is in a
sizegroup that has ignore_hidden == FALSE though, so it may
affect the size group calculations.
However, if a widget is not visible and not in a size group then
its safe to avoid the resize, as the widget will be resized on
becoming visible anyway.
This avoids a lot of size allocation for hidden things like menus
and tooltips.
Alexander Larsson [Tue, 4 Dec 2012 15:36:37 +0000 (16:36 +0100)]
css: Avoid queue_resize in _gtk_widget_style_context_invalidated
We've already emitted style_updated, and the handler for that queues
a resize if necessary.
Alexander Larsson [Mon, 3 Dec 2012 13:30:37 +0000 (14:30 +0100)]
css: Avoid allocations in gtk_css_value_array_compute
Almost all array computations lead to no changes (99% in nautilus)
so we avoid the upfront allocation and delay it until we know its
needed. This drops the allocate/free from the profile.
Alexander Larsson [Mon, 3 Dec 2012 13:29:40 +0000 (14:29 +0100)]
css: Start array allocation with a better size
All computed values will compute all normal properties at least, so
we might as well allocate these upfront, which leads to a lot less
reallocations.
Alexander Larsson [Mon, 3 Dec 2012 12:26:16 +0000 (13:26 +0100)]
css: Use internal return_if_fail in some commonly called code
These are internal apis, and any external issues should have been
caught by checks at public API points. We use the internal checks
here because these checks show up in a non-neglible way on profiles.
Alexander Larsson [Mon, 3 Dec 2012 12:25:14 +0000 (13:25 +0100)]
Add internal versions of g_return_[val_]_if_fail
These are only enabled on debug=yes, so not by default
in released tarballs.
Rico Tzschichholz [Tue, 4 Dec 2012 19:06:19 +0000 (20:06 +0100)]
po: Fix xgettext failing on unicode strings
It is needed to use -from-code=utf-8 to override the ASCII default
Caused by
ceb866dfe6be6d88b8f83a3cbdb8a2a688419c82
Benjamin Otte [Tue, 4 Dec 2012 19:01:45 +0000 (20:01 +0100)]
reftests: Fix wrong name in test
Typo in
d8306aaeb3376d6d11a05b46171300a2b5747606
Alexander Larsson [Tue, 4 Dec 2012 18:56:18 +0000 (19:56 +0100)]
css: Return 0 as change for the GtkSettingsStyleProvider
Marek Kasik [Tue, 4 Dec 2012 14:48:08 +0000 (15:48 +0100)]
printing: Call mark_printer_active() with correct parameters
Revert the second part of the commit
6ad6f719c6b2fc7cf797c86b406f4e61d9fca4d1. mark_printer_active()
was called without its second parameter in g_list_free_full().
Michael Natterer [Tue, 4 Dec 2012 13:31:13 +0000 (14:31 +0100)]
Bug 626499 - GtkClipboard unnotified on change of OS X pasteboard owner
pasteboardChangedOwner is not called as reliably as we'd want to get it,
so keep track of [pasteboard changeCount] and drop clipboard ownership
when a change happened. Also better unset the clipboard content redundantly
in a few places rather than missing one, and reorder the code in
gtk_clipboard_set_contents() so that the new aggressive unsetting
won't unset the clipboard under our feet when we call
[pasteboard declareTypes].
(cherry picked from commit
f2b74db5dcbd28a1e27431f413c66d2a5d50b2bd)
Pierre-Yves Luyten [Mon, 3 Dec 2012 22:46:18 +0000 (23:46 +0100)]
Ensure GtkColorButton has a dialog when adding a palette
https://bugzilla.gnome.org/show_bug.cgi?id=132333
Kalev Lember [Sat, 1 Dec 2012 13:36:13 +0000 (14:36 +0100)]
gtkroundedbox: Fix a compiler warning
Use the correct enum type.
Piotr Drąg [Sat, 1 Dec 2012 20:22:00 +0000 (21:22 +0100)]
Updated POTFILES.skip
Benjamin Otte [Sat, 1 Dec 2012 17:01:39 +0000 (18:01 +0100)]
css: Fix order of enum
We switched around the order in gtkcssenumvalue.h, we need to switch
this order, too. Otherwise the parsing code will go bonkers.
Benjamin Otte [Sat, 1 Dec 2012 15:25:10 +0000 (16:25 +0100)]
reftests: Add a test for the new font size names
Benjamin Otte [Sat, 1 Dec 2012 15:23:08 +0000 (16:23 +0100)]
cssvalue: Fix the scaling factors for 'smaller' and 'larger'
They were reversed. Looks like a bad case of copy/paste failure.
Benjamin Otte [Sat, 1 Dec 2012 15:22:04 +0000 (16:22 +0100)]
cssvalue: Parse font sizes properly
As the last CSS property, font-size now is a proper number (when it's
not a keyword).
Benjamin Otte [Sat, 1 Dec 2012 15:20:47 +0000 (16:20 +0100)]
cssvalue: Change order of values
This is necessary so that the (rather stupid) parsing code doesn't parse
"small" and then is happy when it should instead parse "smaller".
Benjamin Otte [Sat, 1 Dec 2012 13:00:24 +0000 (14:00 +0100)]
css: Fix dependencies for font lookup
'larger' and 'smaller' depend on the parent value. D'oh.
Kalev Lember [Sat, 1 Dec 2012 12:58:41 +0000 (13:58 +0100)]
gtkliststore: Add explicit braces to avoid dangling else
Otherwise the following else becomes attached to the wrong if.
Benjamin Otte [Sat, 1 Dec 2012 13:00:24 +0000 (14:00 +0100)]
css: Add more features to font-size code
We now support the keywords (like xx-small, medium, larger, smaller...)
and I've changed the default value to be "medium".
This required some shuffling of the "get default font size" code. But
all is well now.
Benjamin Otte [Sat, 1 Dec 2012 00:49:06 +0000 (01:49 +0100)]
css: Move default font handling
The default font is no longer handled like a custom style sheet that
overrides everything, but as the initial value. This is the same
behavior as in web browsers.
And it allows the theme to actually use the 'font-family' and
'font-size' properties. Of course, a well behaved theme will respect the
setting as much as possible and for example use relative font sizes
(which aren't yet supported, but will be soon).
Benjamin Otte [Sat, 1 Dec 2012 00:24:12 +0000 (01:24 +0100)]
style: Add _gtk_style_provider_private_get_settings()
This gives a GtkSettings object for resolving system-dependant things -
like the default font family and font size.
No code does this yet, but we have an API.
Only GtkSettings implements this.
Benjamin Otte [Fri, 30 Nov 2012 23:56:12 +0000 (00:56 +0100)]
settings: Implement StyleProvider interface without StyleProperties
I want to deprecate GtkStyleProperties.
Benjamin Otte [Fri, 30 Nov 2012 23:18:01 +0000 (00:18 +0100)]
settings: Never override some font properties
According to the CSS specification, everything but font-size and
font-family are defined by CSS. So we don't override them anymore.
Benjamin Otte [Fri, 30 Nov 2012 21:45:20 +0000 (22:45 +0100)]
API: Deprecate functions to register custom CSS properties
We should slowly transition code to using the GTK-provided CSS. So here
we go.
Benjamin Otte [Fri, 30 Nov 2012 21:41:22 +0000 (22:41 +0100)]
stylecontext: Remove unused private functions
Benjamin Otte [Fri, 30 Nov 2012 19:41:58 +0000 (20:41 +0100)]
cssstyleproperty: Don't mark border width properties as NO_RESIZE
I was to overeager when marking properties in
66d22f101d32630aa3f030585a948d17deb91f4a apparently.
Benjamin Otte [Fri, 30 Nov 2012 19:40:18 +0000 (20:40 +0100)]
widget: Optimize away unndeeded redraws
If only styles were updated that don't require resizes, don't queue one.
Benjamin Otte [Fri, 30 Nov 2012 19:37:46 +0000 (20:37 +0100)]
styleproperty: Add _gtk_css_style_property_changes_affect_size()
This gives fast access to the question of wether a style update requires
a resize.
Benjamin Otte [Fri, 30 Nov 2012 19:36:57 +0000 (20:36 +0100)]
stylecontext: Expose a function to get at the current changes
Benjamin Otte [Fri, 30 Nov 2012 18:00:23 +0000 (19:00 +0100)]
styleproperty: Mark properties as not needing resizes
Benjamin Otte [Fri, 30 Nov 2012 17:57:56 +0000 (18:57 +0100)]
styleproperty: Add an affects-size property
This property will be used to avoid gtk_widget_queue_resize() calls in
favor of gtk_widget_queue_draw().
Benjamin Otte [Fri, 30 Nov 2012 12:58:11 +0000 (13:58 +0100)]
stylecontext: Pass a bitmask to the changed values
Benjamin Otte [Fri, 30 Nov 2012 13:57:02 +0000 (14:57 +0100)]
reftests: Fix a reftest
Recent Adwaita changes caused diffs. We don't want that, so we run this
test against the default settings.
Alexander Larsson [Fri, 30 Nov 2012 15:18:14 +0000 (16:18 +0100)]
icon cache: Fix double free
The symbolic icon cache code free crashed with a double free
due to a missing ->next in the loop.
Michael Natterer [Fri, 30 Nov 2012 14:06:48 +0000 (15:06 +0100)]
gtk: convert keyvals to unicode before committing to the imcontext
(cherry picked from commit
1eb0d98d734d96a6612e320d32a2aded423d2746)
Michael Natterer [Fri, 30 Nov 2012 13:39:42 +0000 (14:39 +0100)]
gtk: add more OSX special casing for the deadacute and deaddoubleacute keys
So " plus foo prduces foo-with-diaereses and ' plus c produces
c-with-cedilla.
(cherry picked from commit
c0102b30894401a9a1d6d93a972bcc6c37f1b5ac)
Alexander Larsson [Fri, 30 Nov 2012 13:18:39 +0000 (14:18 +0100)]
css: Make test pass
The new css tree may change the order of selectors (keeping the
same semantics). This affects how the selectors are printed later,
which causes some css parsing tests to not match the references.
Fortunately the order is consistent between runs given the same
css, so we just have to switch around the order in some of the
.ref.css files.
Alexander Larsson [Thu, 29 Nov 2012 19:52:46 +0000 (20:52 +0100)]
css: Allocate the css tree in a single chunk
This gives us several advantages:
* Smaller struct on 64bit (32bit indexes vs 64bit pointers)
* Less overhead for allocation
* Less fragmentation
Alexander Larsson [Thu, 29 Nov 2012 18:10:57 +0000 (19:10 +0100)]
css: Fix leak of lists while building tree
Alexander Larsson [Thu, 29 Nov 2012 16:56:00 +0000 (17:56 +0100)]
css: Add accessor functions for traversing css tree
This will let us later change how the tree is stored
Alexander Larsson [Thu, 29 Nov 2012 16:55:26 +0000 (17:55 +0100)]
css: Add const to _gtk_css_selector_tree_match_all arg
Alexander Larsson [Thu, 29 Nov 2012 16:28:51 +0000 (17:28 +0100)]
css: Don't keep around linear selectors
Now we use the selector tree everywhere, so there is no need to
keep around the linear selectors unless we're using them to
verify the tree correctness, so free them.
Alexander Larsson [Thu, 29 Nov 2012 16:23:36 +0000 (17:23 +0100)]
css: Remove gtk_css_ruleset_matches
This is only not needed anymore, and only the VERIFY_TREE code
should access ->selector.
Alexander Larsson [Thu, 29 Nov 2012 16:13:59 +0000 (17:13 +0100)]
css: Use tree for gtk_css_provider_get_style_property
Alexander Larsson [Thu, 29 Nov 2012 15:43:02 +0000 (16:43 +0100)]
css: Implement ruleset_get_change() with the tree
We traverse the tree on the matches instead of using
the linear selectors.
Alexander Larsson [Thu, 29 Nov 2012 15:20:14 +0000 (16:20 +0100)]
css: Ensure the tree built is always the same
We add some "artificial" ordering to the otherwise unordered
tree nodes. This means the tree will be the same every time for the
same input. This is good because e.g. tree order affects the
reordering of the simple selectors, which may affect how
css providers are printed, which need to be consistent for
the css tests to work.
Alexander Larsson [Thu, 29 Nov 2012 15:00:01 +0000 (16:00 +0100)]
css: Use the tree to print css selectors
Alexander Larsson [Thu, 29 Nov 2012 14:29:14 +0000 (15:29 +0100)]
css: Track the tree selector matches
Alexander Larsson [Thu, 29 Nov 2012 14:01:47 +0000 (15:01 +0100)]
css: Fix type of GtkCssSelectorRuleSetInfo match
The old type was a leftover from a previous version.
Alexander Larsson [Thu, 29 Nov 2012 13:58:08 +0000 (14:58 +0100)]
css: Track parent in the css tree nodes
This way we can reconstruct matched css rules
Alexander Larsson [Thu, 29 Nov 2012 13:40:10 +0000 (14:40 +0100)]
css: Better tree match verification
Alexander Larsson [Thu, 29 Nov 2012 13:25:53 +0000 (14:25 +0100)]
css: Fix up position with region tree matching
This was using the wrong result in case of a match (results from
the position, not the region. Also, the descendant checks were
wrong.
Alexander Larsson [Thu, 29 Nov 2012 13:21:20 +0000 (14:21 +0100)]
css: Don't reorder some selectors when building selector tree
When building the tree we generally reorder the selectors inside
the same simple selector in order to pick a good first selector
to balance the tree better. However, some kinds of selectors
can't really be reordered, even thought they are simple.
This is since the matching code for some types handle
the existance of a directly preceeding selector differently:
REGION and ANY selectors look for a DESCENDANT previous
POSITION selector look for a REGION previous
Alexander Larsson [Wed, 28 Nov 2012 11:13:09 +0000 (12:13 +0100)]
css: Fixed typo in PRINT_TREE debug code
Alexander Larsson [Wed, 28 Nov 2012 10:21:06 +0000 (11:21 +0100)]
css: Create and use a tree for css selector matching
Alexander Larsson [Wed, 28 Nov 2012 10:15:53 +0000 (11:15 +0100)]
css: Add GtkCssSelectorTree creation and matching
From a set of GtkCssSelectors and the rulesets they match to
we create a large decision tree that lets us efficitently match
against all the rules and return the set of matched rulesets.
The tree is created such that at each level we pick the initial rule[1]
in all the considered selectors for that level and use put the
one that is in most selectors in the node. All selectors matching that
are put in the previous part of the tree.
Alexander Larsson [Wed, 28 Nov 2012 10:07:52 +0000 (11:07 +0100)]
css: Add _gtk_css_matcher_matches_any()
This returns true if the matcher matches *anything*. We need
to check this later, because such matchers are dangerous in loops
that iterate over all parents/siblings since such loops would not
terminate.
Alexander Larsson [Tue, 27 Nov 2012 09:50:59 +0000 (10:50 +0100)]
css: Track which selectors are "simple"
Alexander Larsson [Mon, 26 Nov 2012 12:52:05 +0000 (13:52 +0100)]
Reuse rendered symbolic icons
With the previous commit all loads of the same icon will share a single
GtkIconInfo, which typicallty means the pixbuf is shared via Info->pixbuf.
However, atm we don't share symbolic icons, which causes these to be re-read
and re-parsed every time. This is especially bad if the icon is used many times
in some form of list. So, we cache the pixbufs and reuse them.
https://bugzilla.gnome.org/show_bug.cgi?id=689081
Alexander Larsson [Mon, 26 Nov 2012 12:49:49 +0000 (13:49 +0100)]
Cache GtkIconInfo
In order to avoid loading and keeping around the same icon multiple times
we keep a cache of all outstanding GtkIconInfo objects for a given theme.
Additionally we return to the app not the normal pixbuf from the info,
but rather a proxy copy of it sharing the same data, but no extra
reference. This allows us to track when the app is no longer using
the pixbuf, and we can thus ensure that the GtkIconInfo in the cache
stays around for at least as long as the pixbuf is alive.
When the app unrefs the pixbuf we put the Info on a short LRU list
to keep it alive a bit longer, in case the app needs it in a short
while.
https://bugzilla.gnome.org/show_bug.cgi?id=689081
Matthias Clasen [Fri, 30 Nov 2012 04:18:49 +0000 (23:18 -0500)]
Add a missing va_end call
va_copy must be matched with va_end.
Matthias Clasen [Fri, 30 Nov 2012 04:08:24 +0000 (23:08 -0500)]
Avoid unreachable code
Reestablish an else that went missing in commit
5ff328d2. Without
it, the return is reached unconditionally, and the code behind
it is dead.
Matthias Clasen [Fri, 30 Nov 2012 04:05:07 +0000 (23:05 -0500)]
Don't return prematurely
This code was clearly meant to return _after_ the loop.
Don't put the return inside the loop body, then.
Matthias Clasen [Fri, 30 Nov 2012 04:01:10 +0000 (23:01 -0500)]
GtkAboutDialog: Initialize a variable
Coverity complains about it being uninitialized, otherwise.
Matthias Clasen [Fri, 30 Nov 2012 03:48:27 +0000 (22:48 -0500)]
GtkNotebook: Clarify a switch statement
We were intentionally falling through here, this commit
just adds comments to make that explicit.
Matthias Clasen [Fri, 30 Nov 2012 03:47:02 +0000 (22:47 -0500)]
GtkCellAccessible: Add missing break statements
This switch was entirely breakless. Amazing accessibility code,
found by Coverity.
Matthias Clasen [Fri, 30 Nov 2012 03:45:24 +0000 (22:45 -0500)]
GtkExpander: Clarify a nested switch
This code confused Coverity into thinking we were falling through,
when we were not. Add a few explicit breaks to clear that up.
Matthias Clasen [Fri, 30 Nov 2012 03:42:36 +0000 (22:42 -0500)]
Add a forgotten break in render_border
The GTK_BORDER_STYLE_DOUBLE case was clearly not meant to
fall through to the subsequent cases, yet it did.
Found by Coverity.
Matthias Clasen [Fri, 30 Nov 2012 03:14:12 +0000 (22:14 -0500)]
GtkIconViewAccessible: Fix a copy-paste error
Don't access vadjustment after checking hadjustment for
not being NULL. Found by Coverity.
Matthias Clasen [Fri, 30 Nov 2012 03:12:58 +0000 (22:12 -0500)]
GtkActionHelper: Fix a copy-paste error
The code clearly meant to reset action->active here.
This was found by Coverity.
Matthias Clasen [Fri, 30 Nov 2012 03:09:31 +0000 (22:09 -0500)]
gtk_css_value_bg_size_equal: actually compare contain values
Due to a copy-paste error, the code failed to compare the
contain members of value1 and value2.
This was found by Coverity.
Matthias Clasen [Fri, 30 Nov 2012 03:06:18 +0000 (22:06 -0500)]
Don't check the same crossing mode twice
This was broken since commit
b2aaa94 in 2008. Its commit message
clearly states that the intention was to check for GTK_GRAB,
GTK_UNGRAB and STATE_CHANGED. Lets do that, then.
This was found by Coverity.
Matthias Clasen [Fri, 30 Nov 2012 03:02:16 +0000 (22:02 -0500)]
GtkLabel: Fix a pointless expression
Clearly, what was meant here was that we create a new attribute
list if either of the input attribute lists are non-NULL.
This was found by Coverity.
Matthias Clasen [Sun, 25 Nov 2012 20:45:26 +0000 (15:45 -0500)]
Obtain the recent files max age setting from xsettings
This will help with implementing desktop-wide policy for
retaining of history.
https://bugzilla.gnome.org/show_bug.cgi?id=689047
Timothy Arceri [Sun, 25 Nov 2012 06:05:45 +0000 (17:05 +1100)]
In the file chooser, use a proper apostrophe rather than a prime mark (tick mark)
https://bugzilla.gnome.org/show_bug.cgi?id=689012
Alan McGovern [Fri, 23 Nov 2012 20:38:34 +0000 (15:38 -0500)]
Fix broken function pointer declarations on windows
Both flashing a window and setting the window opacity were using
incorrect declarations for function pointers. They were missing the
WINAPI annotation as defined in windows.h. As a result, the stack
could be corrupted when these functions were invoked.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=689235
(cherry picked from commit
5637ef1f97ee46666c97707ed7f6bae459007163)
Michael Natterer [Thu, 29 Nov 2012 13:51:59 +0000 (14:51 +0100)]
quartz: add mountain lion as version 8 to enum GdkOSXVersion
Also use GDK_OSX_UNSUPPORTED instead of 0 in gdk_quartz_osx_version().
(cherry picked from commit
9644e910a85f97aedf3f5f4fee974229f29766c3)
Michael Natterer [Thu, 29 Nov 2012 13:44:04 +0000 (14:44 +0100)]
quartz: call Gestalt() only once per session in gdk_quartz_osx_version()
Thanks to Paul Davis for pointing this out.
(cherry picked from commit
d6533ffc44d77b42cce7987f249fa481581b7c50)
Benjamin Berg [Sun, 28 Oct 2012 21:19:35 +0000 (22:19 +0100)]
Use the ppd groups "name" instead of "text" (bug #687065)
This commit fixes a regression caused by a patch to remove Cups 1.2
ifdefs. This resulted in the "installable options" to appear in the
print dialog.
Benjamin Otte [Wed, 28 Nov 2012 20:15:05 +0000 (21:15 +0100)]
menuitem: Remove unused variables